[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v16 2/7] remus: introduce remus device
On Fri, Jul 18, 2014 at 10:24 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
No. By default, Remus would enable buffering for both disks and networks. Leaving any one of these devices out would not guarantee consistency.Â
What is happening above is that Remus is trying to enable network buffering if the info->netbuf flag is set (which is the default, unless the user explicitly disables network buffering). ÂA similar check is performed for disks as well.
I think things would be more clearer if the if blocks became something like this: if (info->netbuf) { Â... } else  LOG(WARN, "Network buffering disabled. Failover may not be successful")
ÂA similar if-else block for the disk buffering should help. ÂIn fact, I would suggest pushing these warning statements out to the xl cmdline Âcode, so that even if the user were to filter out all the non-ERROR messages
Âthis warning would always be displayed in the console. [My knowledge of the libxl log filtering is poor. So correct me if I am wrong about this.]
Answered above. There is no way to guarantee consistency upon recovery. I can certainly see use cases for this selective protection. But I consider these as "exceptions" to the normal usage scenarios. Nice to haves, IMO and not a priority ATM.
Â
I am not upto speed on the implementation front. So I'll defer it to Hongyang. Â
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |