Re: [Xen-devel] [PATCH RESEND v9 02/14] arch/arm: let map_mmio_regions() take pfn as parameters

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-07-17 at 13:57 +0100, Ian Campbell wrote:
> On Mon, 2014-07-14 at 02:50 +0200, Arianna Avanzini wrote:
> > Currently, the map_mmio_regions() function, defined for the ARM
> > architecture, has parameters with paddr_t type. This interface,
> > however, needs caller functions to correctly page-align addresses
> > given as parameters to map_mmio_regions(). This commit changes the
> > function's interface to accept page frame numbers as parameters.
> > This commit also modifies caller functions in an attempt to adapt
> > them to the new interface.
> > This commit is meant to produce the minimum indispensable needed
> > changes; these are also instrumental to making the interface of
> > map_mmio_regions() symmetric with the unmap_mmio_regions() function,
> > that will be introduced in one of the next commits of the series
> > and will feature a pfn-based interface.
> > 
> > NOTE: platform-specific code has not been tested, save for the
> >       sunxi and the Arndale Exynos 5 platforms (see the Tested-by
> >       below for the latter).
> > 
> > Signed-off-by: Arianna Avanzini <avanzini.arianna@xxxxxxxxx>
> > Tested-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > Cc: Paolo Valente <paolo.valente@xxxxxxxxxx>
> > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>

Since they represent an interface change which clashes with other
upcoming series I've applied this patch and the next one (arch/arm: let
map_mmio_regions() use start and count).

I had to apply a simple fixlet to the second patch:
diff --git a/xen/arch/arm/platforms/xgene-storm.c 
b/xen/arch/arm/platforms/xgene-storm.c
index 2980c0d..29c4752 100644
--- a/xen/arch/arm/platforms/xgene-storm.c
+++ b/xen/arch/arm/platforms/xgene-storm.c
@@ -47,7 +47,7 @@ static int map_one_mmio(struct domain *d, const char *what,
 
     printk("Additional MMIO %"PRIpaddr"-%"PRIpaddr" (%s)\n",
            start, end, what);
-    ret = map_mmio_regions(d, start, end, end - start + 1, start);
+    ret = map_mmio_regions(d, start, end - start + 1, start);
     if ( ret )
         printk("Failed to map %s @ %"PRIpaddr" to dom%d\n",
                what, start, d->domain_id);

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel