Re: [Xen-devel] [PATCH RFC v1 4/4] libxc for rt scheduler

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-07-11 at 16:49 +0200, Dario Faggioli wrote:

> So, the bouncing logic seems fine. Looking at what other schedulers do,
> there should be no particular need for bouncing anything.

Seems like there is some confusing precedent around the use of sysctl vs
domctl for sched parameters here. 

Most schedulers use domctl but arinc uses sysctl.

All the existing domctl variants use the "inline parameters" scheme
which you quoted, where as arcinc+sysctl uses a pointer to a struct and
bouncing.

This new interface seems to combine the two and uses a domctl with a
pointer. I think it should follow either the existing sysctl or domctl,
not mix the two forms.

Also looking at the new interface added in the first patch I don't think
that array of XEN_LEGACY_MAX_VCPUS elements is going to be sufficient.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel