[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1 03/10] libxl: store a copy of vanilla domain configuration when creating domain

On Thu, Jul 17, 2014 at 12:06:48PM +0100, Ian Campbell wrote:
> Either works for me.
> > And for larger scope, when creating a domain, there shouldn't be any
> > other thread trying to access the configuration file (is there?), so
> > locking is not necessary.
> Could someone race and try and call xl mem-set in the middle of the
> create? Not sure. 

Good point.

To be clear, we don't really care about those moving parts in xenstore,
as we always read from xenstore later to get the latest value.

What concerns me is user doing "xl XXX-attach" etc before the config is

> Always taking the lock when manipulating a domain's stored config, even
> if it isn't strictly necessary means we don't need to think to hard
> about those corner cases...
> I suppose there is also a brief interval after the createdomain domctl
> where the domid is "valid" but no config has been stored yet (since the
> create doesn't hold the lock, I think). You might need some robustness
> against that too.

I think you're right.


> Ian.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.