Re: [Xen-devel] [PATCH] Fix: 'xl vncviewer' accesses port 0 by any invalid domid

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jul 17, 2014 at 02:35:51PM +0800, Chunyan Liu wrote:
[...]
> diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c
> index 1fdf5ea..c689de3 100644
> --- a/tools/libxl/libxl_utils.c
> +++ b/tools/libxl/libxl_utils.c
> @@ -100,6 +100,11 @@ int libxl_domain_qualifier_to_domid(libxl_ctx *ctx, 
> const char *name,
>          }
>      }
>      *domid = strtoul(name, NULL, 10);
> +
> +    /* this could be an invalid domid */
> +    if (!libxl_domid_to_name(ctx, *domid))
> +        return -1;
> +

I think it should return ERROR_*.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel