[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [RFC PATCH 2/3] remus: implement remus checkpoint in v2 save
On 16/07/14 16:22, Shriram Rajagopalan
wrote:
This is partly my fault. I so far havenât got any of the "progress
report" set of logging functionality wired up. Once that is done,
libxl should be fine, as it can already filter the progress logging
from the regular logging.
A thought has just crossed my mind. It might be better to have a
"send_domain_remus()" function which internally deals with the
iterations and looping etc.
e.g.
if ( remus )
ÂÂÂ rc = send_domain_remus(ctx);
else if ( ctx->save.live )
ÂÂÂ rc = send_domain_live(ctx);
else
ÂÂÂ rc = send_domain_memory_nonlive(ctx);
In my upcoming series which fixes the deferred vcpu state problem I
have split some of the common bits out of
send_domain_memory_{live,nonline}() which might be useful.
Even for non-live migrates, we have to ensure that the VM has
entered the suspend state. A PV guest cannot possibly recover from
resume if it didn't voluntarily suspend as it will loose its
reference to the start info page (whos mfn lives in vcpu0.edx for
the duration of the migrate and must be updated on the receiving
side). Any VM which doesn't sufficiently quiesce its fronends risks
ring and memory corruption on resume.
In this case, the send_domain_memory_XXX functions do take care of
pausing the domain at the appropriate time, but this here is a
sanity check.
~Andrew
|
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|