[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH ARM v6 05/14] mini-os: import libfdt

On 16/07/14 13:29, Ian Campbell wrote:
> On Wed, 2014-07-16 at 12:44 +0100, Andrew Cooper wrote:
>> On 16/07/14 12:07, Thomas Leonard wrote:
>>> From: Karim Raslan <karim.allah.ahmed@xxxxxxxxx>
>>> Looks like this is revision v1.3.0-47-gbe60268 from
>>> http://git.jdl.com/gitweb/?p=dtc.git
>>> The memmove implementation is from FreeBSD's
>>> contrib/ldns/compat/memmove.c (r246827).
>>> Signed-off-by: Karim Allah Ahmed <karim.allah.ahmed@xxxxxxxxx>
>>> [talex5@xxxxxxxxx: split out FDT support into a separate patch]
>>> [talex5@xxxxxxxxx: fixed "make clean" for FDT]
>>> [talex5@xxxxxxxxx: replaced GPL memmove with BSD one]
>>> Signed-off-by: Thomas Leonard <talex5@xxxxxxxxx>
>> Xen already has a copy of libfdt in xen/common/libfdt.
> Please review the thread on this from the previous postings.
> Ian.

Which appears to be unconcluded.

libfdt is a 3rd party library which, from what I can tell in the
history, is unmodified.  Therefore, my suggestion of moving it outside
of the xen/ tree and having both minios and Xen VPATH themselves access
to it helps with the end goal of preventing minios becoming dependent on
Xen code.  It further prevents both Xen and minios from accidentally
gaining localisation hacks in the library itself, which makes it easier
to updates to the base libdft if/when necessary.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.