[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Commit dd6d87 breaks serial console

On 14/07/14 17:07, Roger Pau Monné wrote:
> Hello,
> The following commit:
> commit dd6d87a4fcc8350c752e389abb3bcd8479c37555
> Author: Jan Beulich <jbeulich@xxxxxxxx>
> Date:   Fri Jun 20 10:26:37 2014 +0200
>     VT-d: drop redundant calls to invalidate_sync()
>     The call tree iommu_flush_iec_index() -> __iommu_flush_iec() already
>     invokes invalidate_sync(). Removing the superfluous instances at once
>     allows the function to become static.
>     Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>     Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>     Acked-by: Yang Zhang <yang.z.zhang@xxxxxxxxx>
> Breaks serial console on my box, this is all the output I get with this 
> commit applied:

Are you sure you have bisected this correctly?

Unless there is some hardware side-effect of issuing two qinvalidate
wait descriptors back-to-back, the change still looks to be good. 
Alternately, are we missing a hardware erratum for your system?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.