Re: [Xen-devel] [PATCH RFC v1 2/4] xl for rt scheduler

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sun, Jul 13, 2014 at 08:58:01AM -0400, Meng Xu wrote:
[...]
> >
> >
> I think you are right! But I think the implementation of this functionality
> for credit scheduler also has the exactly same issue: scinfo will not be
> disposed when hypercall returns false.
> 

The paradigm was documented not long ago, so I wouldn't be surprised if
there's existing code that violates that paradigm.

In any case we need to make sure new code follows our rule. :-)

> Here is the code for sched_credit_domain_output(int domid) in
> tools/libxl/xl_cmdimpl.c.
>     rc = sched_domain_get(LIBXL_SCHEDULER_CREDIT, domid, &scinfo);
> 
>     if (rc)
> 
>         return rc;
> 
>     domname = libxl_domid_to_name(ctx, domid);
> 
>     printf("%-33s %4d %6d %4d\n",
> 
>         domname,
> 
>         domid,
> 
>         scinfo.weight,
> 
>         scinfo.cap);
> 
>     free(domname);
> 
>     libxl_domain_sched_params_dispose(&scinfo);
> 
> (Note: sched_domain_get() init the scinfo, but didn't dispose it. )
> 
>  As you can see, it has the exact issue I had. :-) If it's the case, I can
> submit a separate patch for this. :-)
> 

That's a good idea.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel