Re: [Xen-devel] [PATCH RFC V2 1/6] xen: Emulate with no writes

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 07/11/2014 07:23 PM, Andrew Cooper wrote:
> On 11/07/14 16:43, Razvan Cojocaru wrote:
>> +void hvm_emulate_one_full(bool_t nowrite,
>> +    unsigned int unhandleable_trapnr,
>> +    int unhandleable_errcode)
>> +{
>> +    struct hvm_emulate_ctxt ctx[1] = {};
> 
> This construct looks suspect.  What is wrong with
> 
> struct hvm_emulate_ctxt ctx = { 0 }; and using &ctx below ?

Modifying the code to address your comments, that code was written to
get around a GCC issue:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119

It's either that or writing

struct hvm_emulate_ctxt ctx = {{ 0 }};

I've changed it to the latter.


Thanks,
Razvan Cojocaru

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel