Re: [Xen-devel] [PATCH RFC V2 2/6] xen: Optimize introspection access to guest state

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/07/14 19:03, Razvan Cojocaru wrote:
> On 07/11/2014 07:54 PM, Andrew Cooper wrote:
>> On 11/07/14 16:43, Razvan Cojocaru wrote:
>>> @@ -1407,6 +1464,9 @@ bool_t p2m_mem_access_check(paddr_t gpa, bool_t 
>>> gla_valid, unsigned long gla,
>>>      if ( p2ma != p2m_access_n2rwx )
>>>          vcpu_pause_nosync(v);
>>>  
>>> +    if ( req )
>>> +        p2m_mem_event_fill_regs(req);
>> Should this not be part of the if ( req ) just above the pause_nosync() ?
> Yes, that would make it more readable. I wanted to make sure that the
> vcpu is paused before filling in register data, but considering the
> context in which this code executes, it shouldn't matter if I just move
> it up.
>
>
> Thanks,
> Razvan Cojocaru

vcpu_pause() & friends are purely scheduler accounting.  Nothing in
there will play with register state.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel