Re: [Xen-devel] Introduce rt real-time scheduler for Xen

[Meng Xu <xumengpanda@xxxxxxxxx>]

âHi Wei and Dario,

â

2014-07-11 7:06 GMT-04:00 Dario Faggioli <dario.faggioli@xxxxxxxxxx>:

On ven, 2014-07-11 at 11:50 +0100, Wei Liu wrote:
> On Fri, Jul 11, 2014 at 12:49:54AM -0400, Meng Xu wrote:
> [...]
> >
> > [PATCH RFC v1 1/4] rt: Add rt scheduler to hypervisor
> > [PATCH RFC v1 2/4] xl for rt scheduler
> > [PATCH RFC v1 3/4] libxl for rt scheduler
> > [PATCH RFC v1 4/4] libxc for rt scheduler
> >
>
> I have some general comments on how you arrange these patches.
>
> At a glance of the title and code you should do them in the order of 1,
> 4, 3 and 2. Apparently xl depends on libxl, libxl depends on libxc, and
> libxc depends on hypervisor. You will break bisection with current
> ordering.
>

Yep, I agree with Wei.

> And we normally write titles like
> Â xen: add rt scheduler
> Â libxl: introduce rt scheduler
> Â xl: XXXX
> Â etc.
> start with component name and separate with colon.
>

Indeed we do, and this helps quite a bit.

> Last but not least, you need to CC relevant maintainers. You can find
> out maintainers with scripts/get_maintainers.pl.
>

Yes, but this one, Meng almost got it right, I think.

Basically, Meng, you're missing hypervisors maintainers (at least for
patch 1). :-)

âThank you very much for your advice!

I will modify them in the next version of the scheduler: 1) rearrange the patch order, 2) change the commit log; 3) add all maintainers.Â

âMengâ

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel