[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type
- To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- From: Daniel Vetter <daniel@xxxxxxxx>
- Date: Fri, 11 Jul 2014 08:29:56 +0200
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "airlied@xxxxxxxx" <airlied@xxxxxxxx>, "intel-gfx@xxxxxxxxxxxxxxxxxxxxx" <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>, "Kay, Allen M" <allen.m.kay@xxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "dri-devel@xxxxxxxxxxxxxxxxxxxxx" <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, "Chen, Tiejun" <tiejun.chen@xxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>
- Delivery-date: Fri, 11 Jul 2014 06:30:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
- Mail-followup-to: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "airlied@xxxxxxxx" <airlied@xxxxxxxx>, "intel-gfx@xxxxxxxxxxxxxxxxxxxxx" <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, "dri-devel@xxxxxxxxxxxxxxxxxxxxx" <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, "Chen, Tiejun" <tiejun.chen@xxxxxxxxx>, "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
On Thu, Jul 10, 2014 at 09:08:24PM +0000, Tian, Kevin wrote:
> actually I'm curious whether it's still necessary to __detect__ PCH. Could
> we assume a 1:1 mapping between GPU and PCH, e.g. BDW already hard
> code the knowledge:
>
> } else if (IS_BROADWELL(dev)) {
> dev_priv->pch_type = PCH_LPT;
> dev_priv->pch_id =
> INTEL_PCH_LPT_LP_DEVICE_ID_TYPE;
> DRM_DEBUG_KMS("This is Broadwell, assuming "
> "LynxPoint LP PCH\n");
>
> Or if there is real usage on non-fixed mapping (not majority), could it be a
> better option to have fixed mapping as a fallback instead of leaving as
> PCH_NONE? Then even when Qemu doesn't provide a special tweaked PCH,
> the majority case just works.
I guess we can do it, at least I haven't seen any strange combinations in
the wild outside of Intel ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
