Re: [Xen-devel] [RFC PATCH v2 6/7] Changed slice to budget in libxc for the sedf scheduler

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On mer, 2014-07-09 at 16:55 -0400, Josh Whitehead wrote:
> From: Robbie VanVossen <robert.vanvossen@xxxxxxxxxxxxxxx>
> 
> Signed-off-by: Robert VanVossen <Robert.VanVossen@xxxxxxxxxxxxxxx>
> Signed-off-by: Nathan Studer <nate.studer@xxxxxxxxx>
> 
> ---
>  tools/libxc/xc_sedf.c             |    8 ++++----
>  tools/libxc/xenctrl.h             |    4 ++--
>  tools/python/xen/lowlevel/xc/xc.c |   20 ++++++++++----------
>  xen/include/public/domctl.h       |    2 +-
>  4 files changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/tools/libxc/xc_sedf.c b/tools/libxc/xc_sedf.c
> index 81ff133..ab67546 100644
> --- a/tools/libxc/xc_sedf.c
> +++ b/tools/libxc/xc_sedf.c
> @@ -28,7 +28,7 @@ int xc_sedf_domain_set(
>      xc_interface *xch,
>      uint32_t domid,
>      uint64_t period,
> -    uint64_t slice,
> +    uint64_t budget,
>
Does this really matter?

'budget' is certainly the most used term in real-time literature and
research, yes, but slice is not that terrible after all. I think it does
get the point across about how one should interpret and use the
parameter itself.

If we were doing a new scheduler, I think I also would pick budget as
the name for this param. If we are to modify SEDF, I honestly think we
can live with 'slice'.

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel