Re: [Xen-devel] [PATCH 1/3] move xenstore public headers to include subdir

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-07-10 at 17:15 +0100, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> ---
>  tools/xenstore/Makefile                |    9 +-
>  tools/xenstore/compat/xs.h             |    2 -
>  tools/xenstore/compat/xs_lib.h         |    2 -
>  tools/xenstore/include/compat/xs.h     |    2 +
>  tools/xenstore/include/compat/xs_lib.h |    2 +
>  tools/xenstore/include/xenstore.h      |  257 
> ++++++++++++++++++++++++++++++++
>  tools/xenstore/include/xenstore_lib.h  |   85 +++++++++++
>  tools/xenstore/xenstore.h              |  257 
> --------------------------------
>  tools/xenstore/xenstore_lib.h          |   85 -----------

Please can you use "git format-patch -M" so the renames are clear.

>  9 files changed, 351 insertions(+), 350 deletions(-)
>  delete mode 100644 tools/xenstore/compat/xs.h
>  delete mode 100644 tools/xenstore/compat/xs_lib.h
>  create mode 100644 tools/xenstore/include/compat/xs.h
>  create mode 100644 tools/xenstore/include/compat/xs_lib.h
>  create mode 100644 tools/xenstore/include/xenstore.h
>  create mode 100644 tools/xenstore/include/xenstore_lib.h
>  delete mode 100644 tools/xenstore/xenstore.h
>  delete mode 100644 tools/xenstore/xenstore_lib.h
> 
> diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
> index e34bd41..2947d3e 100644
> --- a/tools/xenstore/Makefile
> +++ b/tools/xenstore/Makefile
> @@ -6,6 +6,7 @@ MINOR = 3
>  
>  CFLAGS += -Werror
>  CFLAGS += -I.
> +CFLAGS += -I./include

Since you don't change any other Makefiles how do the in-tree consumers
of this library continue to build?

(probably using /usr/include/xenstore_lib.h)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel