[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xen/arm: Correctly support WARN_ON
On 10/07/14 16:06, Ian Campbell wrote: On Tue, 2014-07-01 at 19:51 +0100, Julien Grall wrote:Currently the hypervisor will hang if it hits a WARN_ON. The implemention uses an undefined instruction, made ourself because ARM doesn't provide one, to implement BUG/ASSERT/WARN_ON, and sets up the different tables (one for each type) which contain useful information. This is based on the x86 implementation (include/asm-x86/bug.h). Unfortunately the structure can't be shared because many ARM{32,64} gcc versions doesn't correctly support %c. The support of executing a function in an exception handler is also keep unimplemented on ARM. TODO: I haven't yet hook the code on ARM64 as I'm not sure how undefined instruction are handled. It looks like there is multiple way to get it via HSR. Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>Apart from the lack of arm64 support this looks good to me. I will try to send a new version with the arm64 support next week. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |