Re: [Xen-devel] [RFC PATCH v2 5/7] Add cbs parameter support and removed sedf parameters with a LIBXL_API_VERSION gate from libxl.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [RFC PATCH v2 5/7] Add cbs parameter support and 
removed sedf parameters with a LIBXL_API_VERSION gate from libxl."):
> I previously said that I thought it was fine to remove the obsolete SEDF
> stuff from the libxl API.
> 
> However I mentioned this to the other maintainers and they disagreed
> with me. The feeling is that an old application which used the old SEDF
> parameters should continue to build but that trying to use those
> parameters should result in an error. [...]

Yes.

> I think you can for the most part just remove any code which is behind a
> #if defined(LIBXL_API_VERSION) && LIBXL_API_VERSION <= 0x040400 and
> instead add checks like
>         if (foo->slice != LIBXL_DOMAIN_SCHED_PARAM_SLICE_DEFAULT) 
>                 return ERROR_INVAL; /* deprecated option used */
> at the entry points.
> 
> Ian (J) -- is this the sort of thing you meant?

Yes.  But I agree with what you said later about it perhaps being
easier if we give the new scheduler a new name (at the libxl API
layer, at least).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel