Re: [Xen-devel] [PATCH 09/11] build system: Introduce nosharedlibs variable.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 09/11] build system: Introduce 
nosharedlibs variable."):
> On Mon, 2014-06-30 at 16:52 +0100, Ian Jackson wrote:
> > +ifneq ($(nosharedlibs),y)
> >  INSTALL_SHLIB = $(INSTALL_PROG)
> >  SYMLINK_SHLIB = ln -sf
> >  libextension = .so
> > +else
> > +INSTALL_SHLIB = : install-shlib
> > +SYMLINK_SHLIB = : symlink-shlib
> 
> I don't see install-shlib or symlink-shlib neither in our build system
> nor installed on my usual build machine.

They don't exist.  If they are called it is a bug.  Clearly this is
too confusing.  How about
  +INSTALL_SHLIB = : install-shlib-unsupported-fail
?

I could write
  +INSTALL_SHLIB = : false install shlib unsupported
but "false" doesn't print anything to stderr if it is executed, which
would make the failure more obscure.

> Are these a (Rump)BSD-ism? In which case I expect they won't work for
> minios builds on Linux?
> 
> > +libextension = .a
> > +XENSTORE_STATIC_CLIENTS=y
> 
> Not in tools/xenstored/Makefile?

No.  I felt that XENSTORE_STATIC_CLIENTS was a knob that is exposed by
tools/xenstore/Makefile to the rest of the build system.  And putting
it here puts all the "disable shared libraries" options in the same
place.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel