Re: [Xen-devel] [PATCH v7 15/33] net: xen-netback - set name assign type

[Varka Bhadram <varkabhadram@xxxxxxxxx>]

On 07/10/2014 01:47 PM, Tom Gundersen wrote:
> The name contains then xen handle, which is not guaranteed to be
> stable between restarts, so label this NET_NAME_ENUM.
>
> Signed-off-by: Tom Gundersen <teg@xxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> ---
>   drivers/net/xen-netback/interface.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/xen-netback/interface.c 
> b/drivers/net/xen-netback/interface.c
> index 793275d..da906d1 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -418,8 +418,8 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t 
> domid,
>          * When the guest selects the desired number, it will be updated
>          * via netif_set_real_num_*_queues().
>          */
> -       dev = alloc_netdev_mq(sizeof(struct xenvif), name, NET_NAME_UNKNOWN,
> -                             ether_setup, xenvif_max_queues);
> +       dev = alloc_netdev_mq(sizeof(struct xenvif), name, NET_NAME_ENUM, 
> ether_setup,
> +                             xenvif_max_queues);
What i am suggesting is irrelavent to this patch. But also consider this 
suggestion

In place sizeof(struct xenvif) --> sizeof(*vif) ???

>         if (dev == NULL) {
>                 pr_warn("Could not allocate netdev for %s\n", name);
>                 return ERR_PTR(-ENOMEM);

--
Regards,
Varka Bhadram.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel