Re: [Xen-devel] [PATCH] tools/libxc: Implement writev_exact() in the same style as write_exact() [and 1 more messages]

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Jackson writes ("Re: [PATCH] tools/libxc: Implement writev_exact() in the 
same style as write_exact()"):
> Andrew Cooper writes ("[PATCH] tools/libxc: Implement writev_exact() in the 
> same style as write_exact()"):
> > +int writev_exact(int fd, struct iovec *iov, int iovcnt);
> > +/* Note - writev_exact() might modify iov.  Whether it does so in practice
> > + * depends on whether your system implementation of writev() returns from a
> > + * partial write in the middle of an iov element. */
> 
> The second sentence should be removed.  No-one is allowed to assume
> that writev doesn't do so.  Also, you should mention that your
> writev_exact lacks the atomicity guarantee of proper writev.

Andrew Cooper writes ("Re: [Xen-devel] [PATCH v2] tools/libxc: Implement 
writev_exact() in the same style as write_exact()"):
> Ok - in which case v1 of the patch is correct.  I shall submit v3 which
> looks similar to v1, but with some comments improvements

Please make sure to update the doc comment as I suggest above.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel