[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 2/9] xen: Optimize introspection access to guest state

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Mon, 07 Jul 2014 17:50:07 +0300
  • Cc: tim@xxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Mon, 07 Jul 2014 14:49:41 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=wjgOjrfGSjMSn7CA8OXrzkL0yzgqCWvFU1yD8sAcCYc9ZxP2NTG81ycfQArFsHueHvzjr5QZaLaWHUheteKCGxj5zTlpsoVZFYErYK2VLBSOJyV+ZJu/3o3nhHLnPN08xxjeO14ZN7bdGGyAXYCnR74n021ldonz+4JAAE1k562LO6MuEPxv5nZVblvI2Jo5EltWm6X3wi3/vUeRS6V0jyLnDulW+hmsNJBlRtGF8aHpqxjoSaZvP57GyqQl3axQLujm3Ngy1V93pfIxAEWpZwvnMTHx/LOFaPZf94vavB1fwoo/H+yF/pgu+vAjwsS8C/kj4bsmW9W2fYWTnHRNkQ==; h=Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 07/02/2014 06:31 PM, Andrew Cooper wrote:
> On 02/07/14 14:33, Razvan Cojocaru wrote:
>> Speed optimization for introspection purposes: a handful of registers
>> are sent along with each mem_event. This requires enlargement of the
>> mem_event_request / mem_event_response stuctures, and additional code
>> to fill in relevant values.
>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> The public API already has struct hvm_hw_cpu in
> xen/include/public/arch-x86/hvm/save.h
> It might be better to reuse that rather than defining a new structure to
> contain a subset of the information.

While reinspecting the code to accommodate the critique - the reason why
I've not used struct hvm_hw_cpu back when I initially wrote the patch is
that sizeof(struct hvm_hw_cpu) is considerably larger that the size of
our custom struct. Using hvm_hw_cpu would have filled the mem_event ring
buffer fast, with each mem_event carrying an instance of it around.

Razvan Cojocaru

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.