[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] docs: make .txt files writable when building from r/o sources

On 04/07/14 15:51, Jan Beulich wrote:
>>>> On 04.07.14 at 16:47, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 04/07/14 15:43, Jan Beulich wrote:
>>> Otherwise an incremental build will fail to overwrite the destination
>>> files.
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>> --- a/docs/Makefile
>>> +++ b/docs/Makefile
>>> @@ -125,6 +125,7 @@ endif
>>>  html/%.txt: %.txt
>>>     $(INSTALL_DIR) $(@D)
>>>     cp $< $@
>>> +   chmod u+w $@
>> Perhaps $(INSTALL_DATA) in preference to cp + chmod ?
> I wasn't certain about the validity of the INSTALL_DIR use in a non-
> install rule. If that's indeed fine, then INSTALL_DATA - if it does what
> I want - would likely be the better thing.
> Jan

Because of the somewhat-backwards way the rules are defined, these are
all implicit install rules.

The 'build' rules take the bits from man/ misc/ and figs/ and creates
appropriate structures under man1/ man5/ html/ txt/ and pdf/, while the
'install' rules merely copies the appropriate built structure into

Given the presence of INSTALL_DIR, I would say INSTALL_DATA is
absolutely fine. (with the concession that INSTALL_DIR isn't exactly
nice in that location, as it a huge number of attempts to create
existing directories, and I haven't had sufficient free time to find a
nice fix)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.