Re: [Xen-devel] [PATCH v7a 14/14] xen/arm: Restrict saving of gic register for idle domain

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 1 Jul 2014, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> Check for idle domain is missing before saving gic context.
> Xen stays in hypervisor mode when idle vcpu is running.
> So no need to save and restore context when switched to/from
> idle domain
> 
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>



>  xen/arch/arm/gic.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
> index e1e27b35..c0d70b8 100644
> --- a/xen/arch/arm/gic.c
> +++ b/xen/arch/arm/gic.c
> @@ -70,6 +70,9 @@ void gic_save_state(struct vcpu *v)
>  {
>      ASSERT(!local_irq_is_enabled());
>  
> +    if ( is_idle_vcpu(v) )
> +        return;
> +
>      /* No need for spinlocks here because interrupts are disabled around
>       * this call and it only accesses struct vcpu fields that cannot be
>       * accessed simultaneously by another pCPU.
> -- 
> 1.7.9.5
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel