[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v12 1/9] x86: add generic resource (e.g. MSR) access hypercall
>>> On 04.07.14 at 10:34, <dongxiao.xu@xxxxxxxxx> wrote: > Add a generic resource access hypercall for tool stack or other > components, e.g., accessing MSR, port I/O, etc. Sigh - you're still allocating an unbounded amount of memory for passing around the input arguments, despite it being possible (and having been suggested) to read these from the original buffer on each iteration. You're still not properly checking for preemption between iterations. And you're still not making use of continue_hypercall_on_cpu(). Plus you now silently ignore the upper 32-bits of the passing in "idx" value as well as not understood XEN_RESOURCE_OP_* values. I also doubt that this warrants a new source file to be introduced, the helper functions (if indeed needed) can very well live in platform_hypercall.c. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |