Re: [Xen-devel] [PATCH v9 04/14] arch/arm: unmap partially-mapped I/O-memory regions

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-07-03 at 16:00 +0100, Julien Grall wrote:
> On 07/03/2014 03:40 PM, Ian Campbell wrote:
> > On Wed, 2014-07-02 at 20:42 +0200, Arianna Avanzini wrote:
> >> This commit changes the function apply_p2m_changes() to unwind changes
> >> performed while mapping an I/O-memory region, if errors are seen during
> >> the operation. This is useful to avoid that I/O-memory areas are
> >> partially accessible to guests.
> > 
> > I think it won't quite unwind, since it will actually destroy whatever
> > was there before we tried to put something new.
> > 
> > Is there anything here which is specific to I/O memory areas? It seems
> > to affect all mapping types.
> 
> I think it's fine to unmap for mapping types.

Agreed, but the commit message doesn't reflect that.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel