[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/2] make: Make "src-tarball" target actually make a source tarball
On Thu, 2014-07-03 at 13:48 +0100, George Dunlap wrote: > On 07/03/2014 09:29 AM, Ian Campbell wrote: > > On Wed, 2014-07-02 at 17:15 +0100, George Dunlap wrote: > >> +tdir=$(mktemp -d $xen_root/dist/xen.XXXXXXXX) || exit 1 > > Doesn't set -e make all (or most) of these "|| exit 1" bits unnecessary? > > Er, yes. Sorry. > > > > >> + > >> +mkdir $tdir/xen-$desc || exit 1 > >> + > >> +git archive --format=tar HEAD |tar Cxf $tdir/xen-$desc - || exit 1 > >> + > >> +mkdir $tdir/xen-$desc/tools/qemu-xen || exit 1 > >> +mkdir $tdir/xen-$desc/tools/qemu-xen-traditional || exit 1 > >> + > >> +pushd $xen_root/tools/qemu-xen-traditional-dir-remote || exit 1 > > FWIW I think you could avoid much of this pushd/popd stuff with tar -C > > and git --git-dir= (perhaps --work-dir, not sure for git archive). > > The --git-dir think seemed to work differently enough to hg's "-C" > option that I didn't really trust it. If you think it's better I can > try to work it out. You might need work-dir too? Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |