[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [RFC 08/19] xen/dts: Provide an helper to get a DT node from a path provided by a guest
On Thu, 2014-07-03 at 12:49 +0100, Julien Grall wrote: > Hi Ian, > > On 07/03/2014 12:30 PM, Ian Campbell wrote: > > On Mon, 2014-06-16 at 17:17 +0100, Julien Grall wrote: > >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx> > >> --- > >> xen/common/device_tree.c | 19 +++++++++++++++++++ > >> xen/include/xen/device_tree.h | 17 +++++++++++++++++ > >> 2 files changed, 36 insertions(+) > >> > >> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > >> index 4736e0d..fd95307 100644 > >> --- a/xen/common/device_tree.c > >> +++ b/xen/common/device_tree.c > >> @@ -13,6 +13,7 @@ > >> #include <xen/config.h> > >> #include <xen/types.h> > >> #include <xen/init.h> > >> +#include <xen/guest_access.h> > >> #include <xen/device_tree.h> > >> #include <xen/kernel.h> > >> #include <xen/lib.h> > >> @@ -661,6 +662,24 @@ struct dt_device_node *dt_find_node_by_path(const > >> char *path) > >> return np; > >> } > >> > >> +int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen, > >> + struct dt_device_node **node) > > > > My initial feeling is that this should be a static helper in whichever > > file is using this rather than part of the "dt library" interface. > > It's used in 2 different place (see patch #9 and #12). domtctl and physdev op I think? I suppose device_tree.c isn't so bad, I just felt odd putting guest specific stuff in there. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |