[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC 01/19] xen/arm: guest_physmap_remove_page: Print a warning if we fail to unmap the page

On Mon, 2014-06-16 at 17:17 +0100, Julien Grall wrote:
> The function guest_physmap_remove_page does't have a return value. With
> the change "arch/arm: add consistency check to REMOVE p2m changes",
> apply_p2m_changes can unlikely fail.

Looking at v9 of that patch I don't see it adding any new failures, is
this comment (I suppose written against an older version) still

>  Warn the user in this case.

Given that apply_p2m_changes can fail it seems reasonable to log
regardless of the above:
        Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Two questions:

Would it be better to instead ensure that apply_p2m_changes always logs
on failure? I suppose it would be more able to give a specific message.

On failure do we retain any reference counts to prevent these pages
getting reused?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.