[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 1/9] xen: Emulate with no writes; compute current instruction length

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Thu, 03 Jul 2014 10:42:13 +0300
  • Cc: tim@xxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Thu, 03 Jul 2014 07:41:33 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=hccKkhSKYJWQV61MU0yxSc1rYvDqz99mkFWJFIg9TtKK3I1LFGZae2qo+Q2RsTZ5t3ToUrpgzhppuEX2CswacMG+SBPO5wMA6QIFJzf9hSjaMRLIRMIjWl8HFj67Zz1NB0TRR7Ih8cgaOuMPt3X/GvSwbORCIfHJn9UO1owsNtM2utMeuF+CcO9EHU2qEvzEihjc4hWYm1cb/IoktGKqg9rxx9UF3IkPFgrVysNMtQfLVK8iAK1w3D5CheuWyt/HAtmbEm0b2yFTd3BGZxj6Z8TrGa5ymYRIKzA1m2QjCsvn0jxN9sjZ4kJa4cZTlgxs/LtXA2ixJWZTITUPTt7bqg==; h=Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 07/02/2014 06:20 PM, Andrew Cooper wrote:
> On 02/07/14 14:33, Razvan Cojocaru wrote:
>> Added support for emulating an instruction with no memory writes and
>> for retrieving the length of the next instruction. Additionally,
>> introduced hvm_emulate_one_full(bool_t nowrite), which acts upon all
>> possible return values from the hvm_emulate_one() functions (RETRY,
>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> xen/arch/x86/x86_emulate/ is the core of the emulation in Xen, and this
> looks very much as if it should be part that, rather than wedged on the
> side of the hypervisor.
> Amongst other things, x86_emulate already contains instruction decode
> tables, so it would appear that extending x86_emulate would result in
> less code duplication.

Actually I think I'll break this one into two patches: the emulate
without writes part, which only needs minor modifications according to
Jan's review, and the instruction length part with requires more careful

Razvan Cojocaru

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.