[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RFC 1/9] xen: Emulate with no writes; compute current instruction length
On 07/02/2014 06:20 PM, Andrew Cooper wrote: > On 02/07/14 14:33, Razvan Cojocaru wrote: >> Added support for emulating an instruction with no memory writes and >> for retrieving the length of the next instruction. Additionally, >> introduced hvm_emulate_one_full(bool_t nowrite), which acts upon all >> possible return values from the hvm_emulate_one() functions (RETRY, >> EXCEPTION, UNHANDLEABLE). >> >> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> > > xen/arch/x86/x86_emulate/ is the core of the emulation in Xen, and this > looks very much as if it should be part that, rather than wedged on the > side of the hypervisor. > > Amongst other things, x86_emulate already contains instruction decode > tables, so it would appear that extending x86_emulate would result in > less code duplication. Actually I think I'll break this one into two patches: the emulate without writes part, which only needs minor modifications according to Jan's review, and the instruction length part with requires more careful consideration. Thanks, Razvan Cojocaru _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |