Re: [Xen-devel] [PATCH RFC 1/9] xen: Emulate with no writes; compute current instruction length

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.07.14 at 18:18, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> On 07/02/2014 07:08 PM, Jan Beulich wrote:
>>>>> On 02.07.14 at 17:43, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>> Of course, that means that I can't really explain what the original
>>> author intended (related to the rest of your critique).
>> 
>> Which clearly won't help acceptance of this code, assuming that's
>> your goal.
> 
> Obviously acceptance is the goal, but should the Linux code be cleaned
> up and handed in, or is it better to try to enhance the emulator as has
> been suggested above?

How you deal with issues pointed out in the code you want to
be accepted is up to you: You could fix it locally and diverge from
Linux from the beginning, but the better route perhaps would be
to have the cloned from code fixed first (or at least in parallel).
Of course all that being said leaving aside the much more generic
question of whether to integrate the new functionality with the
existing emulation code instead.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel