Re: [Xen-devel] [PATCH v02 3/3] xen/arm: add DRA7 platform definition

[Andrii Tseglytskyi <andrii.tseglytskyi@xxxxxxxxxxxxxxx>]

Hi Julien,

On Wed, Jul 2, 2014 at 6:18 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> On 07/02/2014 04:02 PM, Andrii Tseglytskyi wrote:
>> Hi Julien,
>
> Hi Andrii,
>
>> Do you mean this code?
>
> Yes. Sorry I wasn't very clear on my previous email.
>
>> +static const struct dt_device_match omap5_blacklist_dev[] __initconst =
>> +{
>> +    /* OMAP Linux kernel handles devices with status "disabled" in a
>> +     * weird manner - tries to reset them. While their memory ranges
>> +     * are not mapped, this leads to data aborts, so skip these devices
>> +     * from DT for dom0.
>> +     */
>> +    DT_MATCH_NOT_AVAILABLE(),
>> +    { /* sentinel */ },
>> +};
>> +
>> +PLATFORM_START(omap5, "TI OMAP5")
>> +    .compatible = omap5_dt_compat,
>> +    .init_time = omap5_init_time,
>> +    .cpu_up = cpu_up_send_sgi,
>> +    .smp_init = omap5_smp_init,
>> +
>> +    .dom0_gnttab_start = 0x4b000000,
>> +    .dom0_gnttab_size = 0x20000,
>> +    *.blacklist_dev = omap5_blacklist_dev,*
>> +PLATFORM_END
>>
>> And do not use standalone DRA7 ?
>
> Right. If case of someone want to keep DRA7 standalone, you will have to
> create 2 distinct compatible list.
>

I would like to create two standalone platform definitions and two
compatible lists. The reason is - common OMAP5 uses specific_mapping
callback, which is not needed by DRA7. In case if we decide to merge
platforms - this should be resolved somehow.
What do you think?

Regards,
Andrii

> Regards,
>
> --
> Julien Grall



-- 

Andrii Tseglytskyi | Embedded Dev
GlobalLogic
www.globallogic.com

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel