[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 5/9] xen: Support for VMCALL mem_events


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Wed, 02 Jul 2014 18:54:53 +0300
  • Cc: tim@xxxxxxx, xen-devel@xxxxxxxxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Wed, 02 Jul 2014 15:54:15 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=ScuApSwQYivPP2tSUIY5CEJ9HZGTlDsVcVYhx8EF3TTu156KXSUFYKd5FhjJvDGtXDZ1C2UkfYSc/UDlsIDny5lIIWLAQ8w7tZJYJxbPZPvujZY6sWKAuzvvv0bBbg2vav1/BKzVVcayHAKAXcQXUsfUq9oErKCZvNlkT4XZx1mW5n9BSX71FOHZw8Wqsmwns8DgsX0LP4D65Bsobii8tAziSvxHH2DLz6RiXHDbN92sYfHyUnEu918YPTIsxfQz12LuxHQwD5lGcgIjBlsVq77MUDIBTM8BEsewybj0+zhUHJ5ACOe5NogzyonPkBK+Ebe9T3T5jnDtYdsvay+ocg==; h=Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

>>  xen/arch/x86/hvm/hvm.c          |    8 ++++++++
>>  xen/arch/x86/hvm/vmx/vmx.c      |   15 ++++++++++++++-
> 
> This is obviously again missing the SVM side.

We've done our development for VMX, that correct.

>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -2880,8 +2880,21 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
>>      case EXIT_REASON_VMCALL:
>>      {
>>          int rc;
>> +        unsigned long eax = regs->eax;
>> +
>>          HVMTRACE_1D(VMMCALL, regs->eax);
>> -        rc = hvm_do_hypercall(regs);
>> +
>> +        if ( regs->eax != 0x494e5452 ) /* Introcore magic */
> 
> Urgh?!

The magic constant is INTR, and it's used to differentiate between
"regular" and induced VMCALLs. Our application sets EAX up like that to
tell the situations apart.

>> --- a/xen/include/public/hvm/params.h
>> +++ b/xen/include/public/hvm/params.h
>> @@ -148,6 +148,8 @@
>>  #define HVM_PARAM_IOREQ_SERVER_PFN 32
>>  #define HVM_PARAM_NR_IOREQ_SERVER_PAGES 33
>>  
>> -#define HVM_NR_PARAMS          34
>> +#define HVM_PARAM_MEMORY_EVENT_VMCALL 34
> 
> So why does this (used only as an argument to
> hvm_memory_event_traps()) need to be settable? I guess the patch
> description is just too brief.

Settable?


Thanks,
Razvan Cojocaru


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.