Re: [Xen-devel] [PATCH RFC 5/9] xen: Support for VMCALL mem_events

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

>>  xen/arch/x86/hvm/hvm.c          |    8 ++++++++
>>  xen/arch/x86/hvm/vmx/vmx.c      |   15 ++++++++++++++-
> 
> This is obviously again missing the SVM side.

We've done our development for VMX, that correct.

>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -2880,8 +2880,21 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
>>      case EXIT_REASON_VMCALL:
>>      {
>>          int rc;
>> +        unsigned long eax = regs->eax;
>> +
>>          HVMTRACE_1D(VMMCALL, regs->eax);
>> -        rc = hvm_do_hypercall(regs);
>> +
>> +        if ( regs->eax != 0x494e5452 ) /* Introcore magic */
> 
> Urgh?!

The magic constant is INTR, and it's used to differentiate between
"regular" and induced VMCALLs. Our application sets EAX up like that to
tell the situations apart.

>> --- a/xen/include/public/hvm/params.h
>> +++ b/xen/include/public/hvm/params.h
>> @@ -148,6 +148,8 @@
>>  #define HVM_PARAM_IOREQ_SERVER_PFN 32
>>  #define HVM_PARAM_NR_IOREQ_SERVER_PAGES 33
>>  
>> -#define HVM_NR_PARAMS          34
>> +#define HVM_PARAM_MEMORY_EVENT_VMCALL 34
> 
> So why does this (used only as an argument to
> hvm_memory_event_traps()) need to be settable? I guess the patch
> description is just too brief.

Settable?


Thanks,
Razvan Cojocaru


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel