Re: [Xen-devel] [PATCH] xen/arm: introduce platform_need_explicit_eoi

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 2 Jul 2014, Julien Grall wrote:
> Hi Stefano,
> 
> The commit title doesn't reflect the patch. You don't add a new
> platform_need_explicit_eoi but a new quirk.

OK

> On 06/20/2014 02:35 PM, Stefano Stabellini wrote:
> > +/*
> > + * Quirk for platforms where GICH_LR_HW does not work as expected.
> > + */
> > +#define PLATFORM_QUIRK_NEED_EOI       (1 << 1)
> > +
> 
> I would rename to PLATFORM_QUIRK_GUEST_PIRQ_NEED_EOI. So people will
> directly know from the name that it's only for guest pirq.

OK

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel