Re: [Xen-devel] [PATCH v2 1/3] xen/atomic: Introduce common atomic header and update includes

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 02/07/14 15:01, Jan Beulich wrote:
>>>> On 02.07.14 at 15:47, <andrew.cooper3@xxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/apic.c
>> +++ b/xen/arch/x86/apic.c
>> @@ -28,7 +28,7 @@
>>  #include <xen/softirq.h>
>>  #include <asm/mc146818rtc.h>
>>  #include <asm/msr.h>
>> -#include <asm/atomic.h>
>> +#include <xen/atomic.h>
> I appreciate you having taken the time to replace all these, but - do
> we really need to do this replacement at this point? Especially arch
> code should be fine using the asm/ header instad of the xen/ one.
>
> Jan
>

Not strictly, but I figured it was cleaner to update everything at once
than to have a mix of common and arch specific includes.

(Also it didn't take long at all.  `git grep ... | xargs sed` is a
remakably quick refactoring tool, and gcc will quickly tell you if it
went wrong)

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel