Re: [Xen-devel] [PATCH] xen/arm: Small fixes after GICv2 changes by commit ee65c87

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 07/02/2014 01:34 PM, Julien Grall wrote:
> The commit ee65c87 moves the GICv2 code in a separate file. Even though this
> patch is only deals with code movement, a comment was modify for no reason.
> 
> Also rename gic_v2_init into gicv2_setup which is what the function does
> and less confusing with the other function called gicv2_init.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> ---
>  xen/arch/arm/gic-v2.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
> index 695c232..74c72d6 100644
> --- a/xen/arch/arm/gic-v2.c
> +++ b/xen/arch/arm/gic-v2.c
> @@ -372,12 +372,12 @@ static void gicv2_clear_lr(int lr)
>      writel_relaxed(0, GICH + GICH_LR + lr * 4);
>  }
>  
> -static int gicv_v2_init(struct domain *d)
> +static int gicv2_setup(struct domain *d)

Hmmmm... I forgot to modify the caller. :/ I will send a v2 right now.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel