Re: [Xen-devel] [PATCH][linux 2.6.18] remove pointless error handling in scsiback

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.07.14 at 14:13, <JGross@xxxxxxxx> wrote:
> On 07/02/2014 01:57 PM, Jan Beulich wrote:
>> @@ -229,8 +230,8 @@ static void __report_luns(pending_req_t
>>      unsigned int req_bufflen = 0;
>>      unsigned int actual_len = 0;
>>      unsigned int retry_cnt = 0;
> 
> When you are cleaning up local variables, IMHO you could remove above 3
> unneeded initializations, too.

Certainly not retry_cnt, but perhaps you meant (apart from the other
two visible here) alloc_luns (immediately prior to the first context line).
Yes, I guess I'll do that.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel