Re: [Xen-devel] [PATCH RFC 02/19] Create efi-shared.[ch], and move string functions

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-06-30 at 12:15 +0100, Jan Beulich wrote:
> >>> On 28.06.14 at 03:25, <roy.franz@xxxxxxxxxx> wrote:
> > Create the files for EFI code that will be shared with the ARM stub,
> > and move string functions and some global variables.
> > 
> > TODO: proper sharing of file (with proper -fshort-char compile option)
> 
> Already at this point of the series I wonder what the value of
> posting it is if even the basic question of placement within the tree
> hasn't been sorted out yet. What are reviewers expected to review
> (considering that code should just be getting moved, not modified)?

I think feedback on the correct placement is useful feedback at this
stage. I think you gave advise in the 00 mail though (xen/common/efi)
which makes sense to me too.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel