Re: [Xen-devel] [PATCH ARM v5 19/20] mini-os: initial ARM support

["karim.allah.ahmed@xxxxxxxxx" <karim.allah.ahmed@xxxxxxxxx>]

On Wed, Jul 2, 2014 at 9:23 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Mon, 2014-06-30 at 20:12 +0100, Thomas Leonard wrote:
>> > IHMO all these changes doesn't belong to the commit message, i.e should not
>> > appear in the commit message when Ian will apply your commit message.
>>
>> As I understand it, as I'm not the author of the patch, it's polite to
>> indicate how I have modified it. I'm trying to follow the guidelines
>> here:
>
> I'm not suggesting you change what you've done here at this stage, but
> for next time:
>
> It's a bit of a judgement call based on the scale of the changes. For
> the number of changes you have done I might have considered making
> myself the "Author" and saying in the commit log "Based on an initial
> patch by Karim, but heavily modified, bugs are all mine" or something
> along those lines etc.
>
> Or if you felt your changes weren't sufficient to justify a change of
> the primary author then a single "Extensively/slightly* modified" (*
> delete as applicable) note would be OK.
>
> The full intra-patch changelog could still usefully go after the "---"
> break to aid reviewers.

I do agree with Ian.

Thomas, feel free to drop me as the author of the patch since you are
heavily modifying the patch anyway. :)


>
> Ian.
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



-- 
Karim Allah Ahmed.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel