Re: [Xen-devel] [BUG] stable-4.4: xen/tools/blktap2/drivers/block-qcow.c build errors

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-06-30 at 18:59 +0200, Leonardo Taccari wrote:
> Hello to the entire Xen community,
> trying to build Xen ARM on Debian GNU/Linux armhf testing gives the
> following errors (doing a "./configure && make dist-tools"):
> 
> [...]
> gcc  -O1 -fno-omit-frame-pointer -marm -g -fno-strict-aliasing -std=gnu99 
> -Wall -Wstrict-prototypes -
> Wdeclaration-after-statement -Wno-unused-but-set-variable 
> -Wno-unused-local-typedefs   -D__XEN_TOOLS_
> _ -MMD -MF .block-qcow.o.d -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
> -D_LARGEFILE64_SOURCE -fno-opti
> mize-sibling-calls  -Werror -g -Wno-unused -fno-strict-aliasing -I../include 
> -I../drivers -I/root/xen
> /tools/blktap2/drivers/../../../tools/libxc 
> -I/root/xen/tools/blktap2/drivers/../../../tools/include 
> -D_GNU_SOURCE -DUSE_NFS_LOCKS  -c -o block-qcow.o block-qcow.c 
> block-qcow.c: In function 'get_cluster_offset':
> block-qcow.c:431:3: error: 'tmp_ptr' may be used uninitialized in this 
> function [-Werror=maybe-uninit
> ialized]
>    memcpy(tmp_ptr, l1_ptr, 4096);
>    ^
> block-qcow.c:606:7: error: 'tmp_ptr2' may be used uninitialized in this 
> function [-Werror=maybe-unini
> tialized]
>    if (write(s->fd, tmp_ptr2, 4096) != 4096) {
>        ^

Thanks for the report.

This was fixed in master with
commit 345e44a85d71a1a910385f33c7f1ba3683026d18
Author: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
Date:   Fri Jun 20 16:09:00 2014 +0200

    blktap2: Fix two 'maybe uninitialized' variables
 
I think this should already be on Ian's list for eventual backport to
4.4, but I've copied him to make sure.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel