[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v7a 09/14] xen/arm: move and rename is_vcpu_running function to sched.h
On 07/01/2014 08:55 AM, Jan Beulich wrote: On 01.07.14 at 08:41, <vijay.kilari@xxxxxxxxx> wrote:@@ -829,6 +829,20 @@ void watchdog_domain_destroy(struct domain *d); #define need_iommu(d) (0) #endif +static inline bool_t is_vcpu_online(const struct domain *d, unsigned int vcpuid)I'm sorry for paying attention to this only now, but a function named this way would ordinarily have a single const struct vcpu * parameter. If the decoding of the (domain, vcpuid) tuple is to remain in the function I guess it ought to be renamed to e.g. is_domain_vcpu_online() +1 (I'd further suggest to drop the is_ prefix, but I realize others may be of different opinion). I'd probably be of the "keep the is_" opinion. :-) -George _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |