Re: [Xen-devel] [PATCH v2 2/3] xen: introduce function merge_free_trunks

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.07.14 at 10:14, <bob.liu@xxxxxxxxxx> wrote:

> On 06/30/2014 11:58 PM, Jan Beulich wrote:
>>>>> On 30.06.14 at 15:39, <lliubbo@xxxxxxxxx> wrote:
>>> --- a/xen/common/page_alloc.c
>>> +++ b/xen/common/page_alloc.c
>>> @@ -831,11 +831,73 @@ static int reserve_offlined_page(struct page_info 
> *head)
>>>      return count;
>>>  }
>>>  
>>> +static void merge_free_trunks(struct page_info *pg, unsigned int order,
>> 
>> Did you perhaps mean merge_free_chunks(), ...
> 
> Oh, yes.
> 
>> 
>>> @@ -891,59 +953,7 @@ static void free_heap_pages(
>>>          }
>>>      }
>>>  
>>> -    /* Merge chunks as far as possible. */
>> 
>> ... taking into consideration this comment the patch removes?
>> 
> 
> I will fix these two issues.

The removal of the comment is not an issue - I was just using this
to help pointing out what the intended naming here is.

> Would you please also take a look at [PATCH v2 3/3]?

Off course - all in due order (this isn't the only thing I have to
take care of, and not highest priority either).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel