[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [libvirt] [PATCH] libxl: don't break the build on Xen>=4.5 because of libxl_vcpu_setaffinity()

On 06/30/2014 03:11 PM, Jim Fehlig wrote:
> Dario Faggioli wrote:
>> libxl interface for vcpu pinning is changing in Xen 4.5. Basically,
>> libxl_set_vcpuaffinity() now wants one more parameter. That is
>> representative of 'VCPU soft affinity', which libvirt does not use.
>> To mark such change, the macro LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY is
>> defined. Use it as a gate and, if present, re-#define the calls from
>> the old to the new interface, to avoid breaking the build.
> Thanks, looks good.  I was about to push, but wanted to check with other
> libvirt devs first since we are in 1.2.6 freeze.  Would it be fine to
> push this?  It fixes a libxl driver build failure against xen-unstable.

Yes, fixing a build failure is an acceptable fix during hard freeze.  Go
ahead and push.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.