Re: [Xen-devel] [OSSTEST PATCH 7/9] standalone-generate-dump-flight-runvars: New utility

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-06-27 at 17:58 +0100, Ian Jackson wrote:
> +    DAILY_BRANCH_POSTMAKE_HOOK='exit 0' \

standalone make-flight sets DAILY_BRANCH_PREEXEC_HOOK, I think with the
same intent. Your one exits earlier but I can't think why we wouldn't
want that to be the default 

> +    ./standalone make-flight -f $flight $branch >$log 2>&1 &
> +    procs+=" $branch=$!"

Don't some branches have things in them which aren't valid in shell
variable names? e.g. "-" and ".".

I think perbranch should produce a var with a sanitized name in it and
use it for the flight name and here.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel