Re: [Xen-devel] [PATCH ARM v5 11/20] mini-os: added HYPERVISOR_xsm_op

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-06-27 at 14:56 +0100, Thomas Leonard wrote:
> On 27 June 2014 14:13, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Thu, 2014-06-26 at 13:38 +0200, Samuel Thibault wrote:
> >> Thomas Leonard, le Thu 26 Jun 2014 12:28:28 +0100, a Ãcrit :
> >> > Avoids using _hypercall1 in events.c.
> >> >
> >> > Signed-off-by: Thomas Leonard <talex5@xxxxxxxxx>
> >>
> >> Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> >
> > On x86 this results in
> >
> > In file included from 
> > stubdom/../extras/mini-os/include/mini-os/gntmap.h:4:0,
> >                  from stubdom/../extras/mini-os/include/mini-os/lib.h:55,
> >                  from stubdom/../extras/mini-os/include/mini-os/mm.h:36,
> >                  from 
> > stubdom/../extras/mini-os/include/x86/x86_64/hypercall-x86_64.h:39,
> >                  from stubdom/../extras/mini-os/include/hypervisor.h:20,
> >                  from mini-os.c:13:
> > stubdom/../extras/mini-os/include/x86/os.h: In function âHYPERVISOR_xsm_opâ:
> > stubdom/../extras/mini-os/include/x86/os.h:566:21: error: expected 
> > expression before âintâ
> >
> > I'm not sure why.
> 
> That's strange. It compiles for me on x86_64 (running "make" in the
> mini-os directory and also running "make" in "stubdom").
> 
> If you tell me the compiler/OS/arch you're on I can try to reproduce it.

Debian Wheezy. I run pre-commit build tests for both 32- and 64-bit but
I'm afraid I don't recall which one had this issue (I should have been
more specific with "x86" above, sorry).

Oh wait, does the fact that it is including hypercall-x86_64.h give us a
clue? I'm not sure if we cross compile stubdoms or not...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel