Re: [Xen-devel] [PATCH ARM v5 11/20] mini-os: added HYPERVISOR_xsm_op

[Thomas Leonard <talex5@xxxxxxxxx>]

On 27 June 2014 14:56, Thomas Leonard <talex5@xxxxxxxxx> wrote:
> On 27 June 2014 14:13, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
>> On Thu, 2014-06-26 at 13:38 +0200, Samuel Thibault wrote:
>>> Thomas Leonard, le Thu 26 Jun 2014 12:28:28 +0100, a Ãcrit :
>>> > Avoids using _hypercall1 in events.c.
>>> >
>>> > Signed-off-by: Thomas Leonard <talex5@xxxxxxxxx>
>>>
>>> Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
>>
>> On x86 this results in
>>
>> In file included from stubdom/../extras/mini-os/include/mini-os/gntmap.h:4:0,
>>                  from stubdom/../extras/mini-os/include/mini-os/lib.h:55,
>>                  from stubdom/../extras/mini-os/include/mini-os/mm.h:36,
>>                  from 
>> stubdom/../extras/mini-os/include/x86/x86_64/hypercall-x86_64.h:39,
>>                  from stubdom/../extras/mini-os/include/hypervisor.h:20,
>>                  from mini-os.c:13:
>> stubdom/../extras/mini-os/include/x86/os.h: In function âHYPERVISOR_xsm_opâ:
>> stubdom/../extras/mini-os/include/x86/os.h:566:21: error: expected 
>> expression before âintâ
>>
>> I'm not sure why.
>
> That's strange. It compiles for me on x86_64 (running "make" in the
> mini-os directory and also running "make" in "stubdom").
>
> If you tell me the compiler/OS/arch you're on I can try to reproduce it.

OK, I see this on x86_32. There's a (pre-existing) cycle in the includes:

hypervisor.h -> hypercall-x86_32.h -> mm.h -> lib.h -> gntmap.h ->
os.h -> hypervisor.h

I could break it at the mm.h -> lib.h link. I can't see why the
low-level MM code needs libc, and it seems to compile without it
(adding some lib.h includes in various C files instead). Any
objections?


-- 
Dr Thomas Leonard        http://0install.net/
GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1
GPG: DA98 25AE CAD0 8975 7CDA  BD8E 0713 3F96 CA74 D8BA

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel