[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6a 17/17] xen/arm: Restrict saving of gic register for idle domain

On 27/06/14 15:52, Ian Campbell wrote:
On Fri, 2014-06-27 at 15:45 +0100, Ian Campbell wrote:
On Thu, 2014-06-26 at 15:33 +0100, Julien Grall wrote:
Hi Vijay,

On 06/26/2014 06:34 AM, vijay.kilari@xxxxxxxxx wrote:
From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>

Check for idle domain is missing before saving gic context

Can you be a bit more verbose to explain why we don't need to save
context for idle vcpu?

There's lots of state you don't need to save for an idle domain, this
one seems pretty clear cut to me.

Although it might be useful to consider whether the tail:
     /* Disable until next VCPU scheduled */
     GICH[GICH_HCR] = 0;
should be done for idle domains too. I suspect yes.

I think we don't care as the virtual CPU interface will never used when an idle VCPU is running.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.