Re: [Xen-devel] [PATCH v10 04/11] xl: enable getting and setting soft affinity

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-06-27 at 15:18 +0200, Dario Faggioli wrote:
> On ven, 2014-06-27 at 13:33 +0100, Ian Campbell wrote:
> > On Fri, 2014-06-20 at 18:19 +0200, Dario Faggioli wrote:
> > > Getting happens via `xl vcpu-list', which now looks like this:
> > 
> > With this I'm seeing:
> >         
> >         xl_cmdimpl.c: In function âvcpupin_parseâ:
> >         xl_cmdimpl.c:661:5: error: passing argument 1 of â__strtok_r_1câ 
> > discards âconstâ qualifier from pointer target type [-Werror]
> >         In file included from /usr/include/string.h:637:0,
> >                          from xl_cmdimpl.c:21:
> >
> Do you? You mean with patches 1-to-4 (this one) applied?

Correct.

>  That's weird,
> as I just performed a clean build of that scenario to verify this, and
> it ended without errors for me.
> 
> It's even more strange as the patch contains the hunk below, which is
> specifically meant at avoiding what you report... :-O

But strtok_r takes a non-const char *, so when you pass the now const
cpu to it you get exactly this error, don't you?

> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -656,7 +656,7 @@ static int update_cpumap_range(const char *str,
> libxl_bitmap *cpumap)
>   * single cpus or as eintire NUMA nodes) and turns it into the
>   * corresponding libxl_bitmap (in cpumap).
>   */
> -static int vcpupin_parse(char *cpu, libxl_bitmap *cpumap)
> +static int vcpupin_parse(const char *cpu, libxl_bitmap *cpumap)
>  {
>      char *ptr, *saveptr = NULL;
>      int rc = 0;
> 
> Anyway, to be sure, I just compile tested the full series, patch after
> patch, and that also went well.
> 
> I'm not sure what's going on!

My compiler is stricter than yours?

I'm building on Debian Wheezy, specifically on the machine "cosworth"
here in Cambridge. You should have access...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel