Re: [Xen-devel] [PATCH v6a 03/17] xen/arm: make sgi handling generic

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-26 at 11:03 +0530, vijay.kilari@xxxxxxxxx wrote:
> @@ -512,18 +531,18 @@ void send_SGI_self(enum gic_sgi sgi)
>  
>      dsb(sy);
>  
> -    GICD[GICD_SGIR] = GICD_SGI_TARGET_SELF
> -        | sgi;
> +    send_SGI(sgi, SGI_TARGET_SELF, cpumask_of(smp_processor_id()));

You should pass NULL here. As I said on v5 If the gicv3 code needs to
create a mask then it should do so based on gic_sgi_mode only.

> +   send_SGI(sgi, SGI_TARGET_OTHERS, &all_others_mask);

Likewise here.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel