Re: [Xen-devel] [PATCH v2 1/3] [GSOC14] refactored mempaging code from xenpaging to libxc.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-06-27 at 16:09 +0530, Dushyant Behl wrote:
> Please don't apply the patch yet. I have found a very small yet big
> mistake with the patch.
> I'll send the correct patch along with these things updated correctly.

OK.

In the meantime I noticed that it doesn't compile for 32-bit either:

xc_mem_paging_setup.c: In function 'xc_mem_paging_ring_setup':
xc_mem_paging_setup.c:50:5: error: passing argument 4 of 'xc_get_hvm_param' 
from incompatible pointer type [-Werror]
In file included from xc_private.h:32:0,
                 from xc_mem_paging_setup.c:26:
xenctrl.h:1867:5: note: expected 'long unsigned int *' but argument is of type 
'uint64_t *'
xc_mem_paging_setup.c:53:41: error: passing argument 4 of 
'xc_map_foreign_batch' from incompatible pointer type [-Werror]
In file included from xc_private.h:32:0,
                 from xc_mem_paging_setup.c:26:
xenctrl.h:1431:7: note: expected 'xen_pfn_t *' but argument is of type 
'uint64_t *'
xc_mem_paging_setup.c:58:47: error: passing argument 6 of 
'xc_domain_populate_physmap_exact' from incompatible pointer type [-Werror]
In file included from xc_private.h:32:0,
                 from xc_mem_paging_setup.c:26:
xenctrl.h:1326:5: note: expected 'xen_pfn_t *' but argument is of type 
'uint64_t *'
xc_mem_paging_setup.c:67:41: error: passing argument 4 of 
'xc_map_foreign_batch' from incompatible pointer type [-Werror]
In file included from xc_private.h:32:0,
                 from xc_mem_paging_setup.c:26:
xenctrl.h:1431:7: note: expected 'xen_pfn_t *' but argument is of type 
'uint64_t *'
xc_mem_paging_setup.c:114:5: error: passing argument 5 of 
'xc_domain_decrease_reservation_exact' from incompatible pointer type [-Werror]
In file included from xc_private.h:32:0,
                 from xc_mem_paging_setup.c:26:
xenctrl.h:1307:5: note: expected 'xen_pfn_t *' but argument is of type 
'uint64_t *'
cc1: all warnings being treated as errors



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel