Re: [Xen-devel] [PATCH v10 08/11] xl: move away from the (deprecated) use of cpumap for hard affinity

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On ven, 2014-06-27 at 12:00 +0100, Ian Campbell wrote:
> On Fri, 2014-06-20 at 18:19 +0200, Dario Faggioli wrote:
> > +        const char *buf2 = NULL; //XXX Trick the compiler!!!
> 
> This comment needs to be removed one way or another...
> 
Wow, sorry. I could have sworn I removed it before posting! :-(

> I'm unsure about the "= NULL" since I'm not sure what it is trying to
> achieve.
> 
Ok, Now I've seen what happened. I removed the comment from the wrong
patch, and then did not realize the fact that it made it into the series
in two other patches. Will fix this.

Anyway, the explanation of why I think I need the =NULL is in patch 10,
when the comment is actually replaced with something more sensible.

It would be wonderful if you could at least have a look at that hunk,
and tell me whether you think the reasoning behind suppressing the
warning is sound, and the explanation clear enough.

Thanks in advance,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel